+2 -1

.github/workflows/ci.yml

Reviewed

··· 8 8 jobs: 9 9 test: 10 10 runs-on: ubuntu-latest 11 11 - container: alpine:edge # go1.19 needs > alpine 3.15 11 11 + # Pinned to alpine 3.19 to fix go version to 1.21. Remove this once Sourcegraph is on Go 1.22. 12 12 + container: alpine:3.19 12 13 steps: 13 14 - name: checkout 14 15 uses: actions/checkout@v3

-8

api.go

Reviewed

··· 892 892 // be set to 1 to find all repositories containing a result. 893 893 ShardRepoMaxMatchCount int 894 894 895 895 - // Deprecated: this field is not read anymore. 896 896 - ShardMaxImportantMatch int 897 897 - 898 898 - // Deprecated: this field is not read anymore. 899 899 - TotalMaxImportantMatch int 900 900 - 901 895 // Abort the search after this much time has passed. 902 896 MaxWallTime time.Duration 903 897 ··· 986 980 addInt("ShardMaxMatchCount", s.ShardMaxMatchCount) 987 981 addInt("TotalMaxMatchCount", s.TotalMaxMatchCount) 988 982 addInt("ShardRepoMaxMatchCount", s.ShardRepoMaxMatchCount) 989 989 - addInt("ShardMaxImportantMatch", s.ShardMaxImportantMatch) 990 990 - addInt("TotalMaxImportantMatch", s.TotalMaxImportantMatch) 991 983 addInt("MaxDocDisplayCount", s.MaxDocDisplayCount) 992 984 addInt("MaxMatchDisplayCount", s.MaxMatchDisplayCount) 993 985 addInt("NumContextLines", s.NumContextLines)

-3

api_proto_test.go

Reviewed

··· 335 335 t.Run("SearchOptions", func(t *testing.T) { 336 336 f := func(f1 *SearchOptions) bool { 337 337 if f1 != nil { 338 338 - // Ignore deprecated and unimplemented fields 339 339 - f1.ShardMaxImportantMatch = 0 340 340 - f1.TotalMaxImportantMatch = 0 341 338 f1.SpanContext = nil 342 339 } 343 340 p1 := f1.ToProto()