fork of https://github.com/sourcegraph/zoekt
docker: change our default GOGC to 25 (#399)
We had a regression in go1.18 in our memory usage. From experimentation
we have found a value of 25 gave us the same stable size from before
1.18.
Note: we set GOGC for all containers, but really we only should be doing
this for webserver. However, I don't want to bundle that change into
this one.
Test Plan: we have validated this on sourcegraph.com over the last few
weeks.
author
Keegan Carruthers-Smith
committer
GitHub
date
(Jul 13, 2022, 1:57 PM +0200)
commit
42276b7b
42276b7b7095418f8b55cae2224b7ba34815b13b
parent
f7f68fd7
f7f68fd7f337c50a17ab24138b9b3d144a87c4d8
+9
-3
+3
-1
Dockerfile
+3
-1
Dockerfile
···
25
25
26
26
# zoekt-webserver has a large stable heap size (10s of gigs), and as such the
27
27
# default GOGC=100 could be better tuned. https://dave.cheney.net/tag/gogc
28
-
ENV GOGC=50
28
+
# In go1.18 the GC changed significantly and from experimentation we tuned it
29
+
# down from 50 to 25.
30
+
ENV GOGC=25
29
31
30
32
ENTRYPOINT ["/sbin/tini", "--"]
+3
-1
Dockerfile.indexserver
+3
-1
Dockerfile.indexserver
···
24
24
25
25
# zoekt indexing has a large stable heap size (gigs), and as such the default
26
26
# GOGC=100 could be better tuned. https://dave.cheney.net/tag/gogc
27
-
ENV GOGC=50
27
+
# In go1.18 the GC changed significantly and from experimentation we tuned it
28
+
# down from 50 to 25.
29
+
ENV GOGC=25
28
30
29
31
ENTRYPOINT ["/sbin/tini", "--", "zoekt-sourcegraph-indexserver"]
+3
-1
Dockerfile.webserver
+3
-1
Dockerfile.webserver
···
18
18
19
19
# zoekt-webserver has a large stable heap size (10s of gigs), and as such the
20
20
# default GOGC=100 could be better tuned. https://dave.cheney.net/tag/gogc
21
-
ENV GOGC=50
21
+
# In go1.18 the GC changed significantly and from experimentation we tuned it
22
+
# down from 50 to 25.
23
+
ENV GOGC=25
22
24
23
25
ENTRYPOINT ["/sbin/tini", "--"]
24
26
CMD zoekt-webserver -index $DATA_DIR -pprof -rpc