fork of https://github.com/sourcegraph/zoekt
Enable go-git optimization by default (#856)
The go-git optimizations have been running well on dot-com, so this PR enables
them by default. I'll remove the flag entirely once these optimizations have
been released to more instances.
author
Julie Tibshirani
committer
GitHub
date
(Nov 4, 2024, 10:21 AM -0800)
commit
4f038fd8
4f038fd84b02188dfaebf0fb9570325868e7ca55
parent
aa6050a0
aa6050a078a549b4786b36a0a1a196145d92dec4
+7
-8
+7
-8
gitindex/index.go
+7
-8
gitindex/index.go
···
408
408
opts.BuildOptions.RepositoryDescription.Source = opts.RepoDir
409
409
410
410
var repo *git.Repository
411
-
412
411
// TODO: remove this feature flag once we test this on a large-scale instance.
413
-
optimizeRepoOpen := os.Getenv("ZOEKT_ENABLE_GOGIT_OPTIMIZATION")
414
-
if b, err := strconv.ParseBool(optimizeRepoOpen); b && err == nil {
412
+
legacyRepoOpen := os.Getenv("ZOEKT_DISABLE_GOGIT_OPTIMIZATION")
413
+
if b, err := strconv.ParseBool(legacyRepoOpen); b && err == nil {
414
+
repo, err = git.PlainOpen(opts.RepoDir)
415
+
if err != nil {
416
+
return false, fmt.Errorf("git.PlainOpen: %w", err)
417
+
}
418
+
} else {
415
419
var repoCloser io.Closer
416
420
repo, repoCloser, err = openRepo(opts.RepoDir)
417
421
if err != nil {
418
422
return false, fmt.Errorf("openRepo: %w", err)
419
423
}
420
424
defer repoCloser.Close()
421
-
} else {
422
-
repo, err = git.PlainOpen(opts.RepoDir)
423
-
if err != nil {
424
-
return false, fmt.Errorf("git.PlainOpen: %w", err)
425
-
}
426
425
}
427
426
428
427
if err := setTemplatesFromConfig(&opts.BuildOptions.RepositoryDescription, opts.RepoDir); err != nil {