fork of https://github.com/sourcegraph/zoekt
zoekt-indexserver: Prevent invalid config from causing an NPE (#612)
When the user specifies an invalid mirror config that contains an entry
without any of the GithubUser / GithubOrg / ... repository definitions,
zoekt-indexserver would crash, because `cmd` stays `nil` and causes a
SIGSEGV when it is later accessed in `main.executeMirror`.
author
Philipp Wollermann
committer
GitHub
date
(Jul 12, 2023, 9:18 AM +0200)
commit
9abbb8b0
9abbb8b0d3470c76b628feb6f00d3cc5916d4dba
parent
25c1ea51
25c1ea5177fbd5ab817031b44afcc53c2015d5c9
+3
+3
cmd/zoekt-indexserver/config.go
+3
cmd/zoekt-indexserver/config.go
···
260
260
cmd.Args = append(cmd.Args, "-active")
261
261
}
262
262
cmd.Args = append(cmd.Args, c.GerritApiURL)
263
+
} else {
264
+
log.Printf("executeMirror: ignoring config, because it does not contain any valid repository definition: %q", c)
265
+
continue
263
266
}
264
267
265
268
stdout, _ := loggedRun(cmd)