fork of https://github.com/sourcegraph/zoekt
fix: Escape language queries correctly (#1003)
`escape` escapes certain characters, but those don't include `+`, so clicking a `C++` language link will result in the `+`s not being escaped in the URL. This causes the search to search for `"C "` which finds no results.
`encodeURIComponent` is what should be used.
author
Daryl Haresign
committer
GitHub
date
(Jan 14, 2026, 4:38 PM +0200)
commit
c747a3bc
c747a3bccc2a4a427204ac08eea62a522df6d2ec
parent
886b229d
886b229dcd5e7bec0c9918002b77345d27c84e3c
+1
-1
+1
-1
web/templates.go
+1
-1
web/templates.go
···
213
213
<title>Results for {{.QueryStr}}</title>
214
214
<script>
215
215
function zoektAddQ(atom) {
216
-
window.location.href = "/search?q=" + escape("{{.QueryStr}}" + " " + atom) +
216
+
window.location.href = "/search?q=" + encodeURIComponent("{{.QueryStr}}" + " " + atom) +
217
217
"&" + "num=" + {{.Last.Num}};
218
218
}
219
219
</script>