fork of https://github.com/sourcegraph/zoekt
gitindex: disable gogit optimization by default (#870)
We have seen issues on large repos so lets default to off until we fix
again.
author
Keegan Carruthers-Smith
committer
GitHub
date
(Dec 3, 2024, 10:54 AM +0200)
commit
cb9599a0
cb9599a0684c48d5a3ffcec81a48d5358fd1a547
parent
333dfefd
333dfefd5a06a63bd39e400306fd7a76b9f6487e
+5
-3
+5
-3
gitindex/index.go
+5
-3
gitindex/index.go
···
17
17
18
18
import (
19
19
"bytes"
20
+
"cmp"
20
21
"context"
21
22
"errors"
22
23
"fmt"
···
408
409
opts.BuildOptions.RepositoryDescription.Source = opts.RepoDir
409
410
410
411
var repo *git.Repository
411
-
// TODO: remove this feature flag once we test this on a large-scale instance.
412
-
legacyRepoOpen := os.Getenv("ZOEKT_DISABLE_GOGIT_OPTIMIZATION")
413
-
if b, err := strconv.ParseBool(legacyRepoOpen); b && err == nil {
412
+
// TODO: this now defaults to on since we found a bug in it. Once we have
413
+
// fixed openRepo default to false.
414
+
legacyRepoOpen := cmp.Or(os.Getenv("ZOEKT_DISABLE_GOGIT_OPTIMIZATION"), "true")
415
+
if b, err := strconv.ParseBool(legacyRepoOpen); b || err != nil {
414
416
repo, err = git.PlainOpen(opts.RepoDir)
415
417
if err != nil {
416
418
return false, fmt.Errorf("git.PlainOpen: %w", err)