zoekt/query/ at 05b2b92c2ebd0927249db50155dfe7375e0ed525 · boltless.me/zoekt · Tangled

boltless.me / zoekt

0

fork of https://github.com/sourcegraph/zoekt

0

zoekt / query /

at 05b2b92c2ebd0927249db50155dfe7375e0ed525 12 files

Stefan Hengl sourcegraph-indexserver: add grpc server (#920) 1y ago

sourcegraph-indexserver: add grpc server (#920) Relates to SPLF-874 This adds a grpc server to sourcegraph-indexserver. For now it supports just one method. The diff is quite big, so I left comments to mark the most important bits. I used the opportunity to clean up a bit (=> hence the big diff): - Reuse grpc logic from webserver and move those bits to "/gprc/..." - Move "protos" inside the new "grpc" directory (=> requires changes of import statements in Sourcegraph) - Refactor import aliases for grpc packages across the codebase Test plan: I tested this locally by calling the new grpc endpoint directly.

1 year ago

Document all the commands + packages (#904) This PR adds doc comments for all packages/ commands.

1 year ago

query: introduce FileNameSet (#482) Sourcegraph's new hybrid searcher sends around large ORs of filenames to search for. FileNameSet provides an efficient implementation to transport and query these sets of filenames. We include an efficient gob implementation based on previous work around encoding a more complicated map of strings. Test Plan: Added unit tests. Additionally, updated sourcegraph to use this implementation and ran its tests.

3 years ago

marshal_test.go

query: introduce FileNameSet (#482) Sourcegraph's new hybrid searcher sends around large ORs of filenames to search for. FileNameSet provides an efficient implementation to transport and query these sets of filenames. We include an efficient gob implementation based on previous work around encoding a more complicated map of strings. Test Plan: Added unit tests. Additionally, updated sourcegraph to use this implementation and ran its tests.

3 years ago

Add support for Magik and PKl languages that are not handled by Linguist (#790) Add fallbacks for languages not supported yet by linguist or go-enry

2 years ago

query: parse support for `fork:` and `public:` (#550) Add support for parsing queries for zoekt.fork and zoekt.public.

3 years ago

query: simplify empty BranchesRepos and RepoIDs (#855) We recently had an incident where this was accidently unset and lead to lots of work done by zoekt which just got thrown away. Test Plan: added unit test

2 years ago

sourcegraph-indexserver: add grpc server (#920) Relates to SPLF-874 This adds a grpc server to sourcegraph-indexserver. For now it supports just one method. The diff is quite big, so I left comments to mark the most important bits. I used the opportunity to clean up a bit (=> hence the big diff): - Reuse grpc logic from webserver and move those bits to "/gprc/..." - Move "protos" inside the new "grpc" directory (=> requires changes of import statements in Sourcegraph) - Refactor import aliases for grpc packages across the codebase Test plan: I tested this locally by calling the new grpc endpoint directly.

1 year ago

query_proto_test.go

all: gofumpt -l -w . gofumpt is a stricter gofmt. I took a look at the changes and in general they are nice. I don't think we need to enforce the use of gofumpt, but I like the idea of running it every once in a while. Test Plan: go test ./...

2 years ago

query: simplify empty BranchesRepos and RepoIDs (#855) We recently had an incident where this was accidently unset and lead to lots of work done by zoekt which just got thrown away. Test Plan: added unit test

2 years ago

all: use a faster vendored regexp/syntax/Regexp.String (#753) We replace all calls to Regexp.String with a vendored version which is faster. go1.22 introduced a commit which "minimizes" the string returned by Regexp.String(). Part of what it does is run enumerate through literals runes in your string to see calculate flags related to unicode and case sensitivity. This can be quite slow, but is made worse by the fact we call it per shard per regexp in your query.Q to construct the matchtree. Currently Regexp.String() represents 40% of CPU time on sourcegraph.com. Before go1.22 it was ~0%. Note: This is a temporary change to resolve the issue. I have a deeper change to make this less clumsy. Note: In one place we remove the use of string by relying on Regexp.Equal instead. Test Plan: go test

2 years ago

all: use a faster vendored regexp/syntax/Regexp.String (#753) We replace all calls to Regexp.String with a vendored version which is faster. go1.22 introduced a commit which "minimizes" the string returned by Regexp.String(). Part of what it does is run enumerate through literals runes in your string to see calculate flags related to unicode and case sensitivity. This can be quite slow, but is made worse by the fact we call it per shard per regexp in your query.Q to construct the matchtree. Currently Regexp.String() represents 40% of CPU time on sourcegraph.com. Before go1.22 it was ~0%. Note: This is a temporary change to resolve the issue. I have a deeper change to make this less clumsy. Note: In one place we remove the use of string by relying on Regexp.Equal instead. Test Plan: go test

2 years ago