zoekt/ctags/ at 0f685d8993a5e70bbffc31aaf06b1a93e7ffb583 · boltless.me/zoekt · Tangled

boltless.me / zoekt

0

fork of https://github.com/sourcegraph/zoekt

0

zoekt / ctags /

at 0f685d8993a5e70bbffc31aaf06b1a93e7ffb583 4 files

Julie Tibshirani ctags: require scip-ctags to be present (#700) 2y ago

ctags: require scip-ctags to be present (#700) Previously, we didn't require that scip-ctags be available even if if you set `require_ctags` and set `language_map` to something like `go:scip`. Instead, we silently fell back to `universal-ctags`. This is tricky and could mask a real issue where we expect scip-ctags to be available but it isn't. Now, we check if SCIP is needed based on `language_map`, and if so require that scip-ctags is available.

2 years ago

ctags: allow binary to be anything with validation (#652) Previously we enforced the binary was called universal-ctags. However, we let users override the name of the binary, so if they override it we should use it. To prevent footguns, we now validate the binary was built with the interactive feature. In the case of scip-ctags we use the old validation of just checking the name. Additionally we fix a bug that was introduced where if symbols are optional we continue if parsing fails. Test Plan: indexed with and without universal-ctags. Ctags on my mbp points to something from xcode which wouldn't work $ CTAGS_COMMAND=ctags go run ./cmd/zoekt-git-index -require_ctags . 2023/10/04 17:08:12 indexGitRepo(/Users/keegan/src/github.com/sourcegraph/zoekt, delta=false): build.NewBuilder: ctags.NewParserMap: ctags binary is not universal-ctags or is not compiled with +interactive feature: bin=ctags exit status 1 $ CTAGS_COMMAND=universal-ctags go run ./cmd/zoekt-git-index -require_ctags . 2023/10/04 17:08:29 finished github.com%2Fsourcegraph%2Fzoekt_v16.00000.zoekt: 8657338 index bytes (overhead 2.9) $ CTAGS_COMMAND=ctags go run ./cmd/zoekt-git-index . 2023/10/04 17:08:40 finished github.com%2Fsourcegraph%2Fzoekt_v16.00000.zoekt: 8538246 index bytes (overhead 2.9)

2 years ago

ctags: require scip-ctags to be present (#700) Previously, we didn't require that scip-ctags be available even if if you set `require_ctags` and set `language_map` to something like `go:scip`. Instead, we silently fell back to `universal-ctags`. This is tricky and could mask a real issue where we expect scip-ctags to be available but it isn't. Now, we check if SCIP is needed based on `language_map`, and if so require that scip-ctags is available.

2 years ago

Ranking: standardize ctags kind names before scoring (#674) SCIP ctags can output different kind names than universal-ctags (for example `typeAlias` instead of `talias`). This change makes sure we handle different names for the same kind. To do so, it refactors the logic so we first match strings to standard kinds, then decide how these are scored for each language. That way, you don't need to remember to cover all the possible kind names each time you adjust scoring for a new language. Also added basic tests for Ruby and Python to ensure we don't accidentally change the scoring.

2 years ago