zoekt/shards/ at 43b92256ba7117270d7cc8ca434cc14faf2cc241 · boltless.me/zoekt · Tangled

boltless.me / zoekt

0

fork of https://github.com/sourcegraph/zoekt

0

zoekt / shards /

at 43b92256ba7117270d7cc8ca434cc14faf2cc241 9 files

Keegan Carruthers-Smith Revert "shards: respect scheduler and use smarter synchronization for List (#750)" (#752) 2y ago

Revert "shards: respect scheduler and use smarter synchronization for List (#750)" (#752) This reverts commit 931974dd953e07ce8fbe28e3b615323c2d156e40. After monitoring production we are seeing increased latencies in List calls. Additionally we are seeing many more scheduler transitions into interactive queued. The only realistic cause of this was this commit, so we are reverting for now until further investigation. Test Plan: go test

2 years ago

shards: always aggregate stats for tracing (#729) Many a time I have seen a slow search without tracing turned on. I then go to visit the net/trace page to see what happened but it is missing the stats to try work out why. This commit will ensure we always log the aggregated statistics. This should be cheap to do given Add is relatively fast and LazyPrintf will only do the stringer operation if someone loads the debug page. It does mean a Stats object lives a bit longer in memory, but it is small. Test Plan: go test

2 years ago

all: rename module to github.com/sourcegraph/zoekt We are a hard enough for now that we might as well have our own module name. This will also make it possible to more directly use go tooling.

3 years ago

scheduler: add some clarifying comments (#508)

3 years ago

all: fix errcheck lints in test files

4 years ago

Revert "shards: respect scheduler and use smarter synchronization for List (#750)" (#752) This reverts commit 931974dd953e07ce8fbe28e3b615323c2d156e40. After monitoring production we are seeing increased latencies in List calls. Additionally we are seeing many more scheduler transitions into interactive queued. The only realistic cause of this was this commit, so we are reverting for now until further investigation. Test Plan: go test

2 years ago

shards: selectRepoSet supports queries which are not wrapped in and (#751) The previous commit which added support for selectRepoSet in List was ineffective since the queries we get for List do not look like (and ...) but instead directly specify the reposet atom. This commit adds support for it. Additionally to help with our manual testing we add support for "repo:" query in the selectRepoSet optimization. While pairing on this we decided to improve the debug output to tracing and rename the misnamed query.Q variable in List from r to q. Test Plan: updated the test case to directly test the sort of queries we get in List calls. Additionally ran "zoekt-webserver -pprof" and observed in net/trace output that selectRepoSet optimization reduced the number of searched shards. Co-authored-by: Stefan Hengl <stefan@sourcegraph.com>

2 years ago

Fix no-shards-loaded being reported as crashes (#512) Full debug context here: https://sourcegraph.slack.com/archives/C023ELQLV7F/p1672835804462349 Commit 9899a9b3f475ef066ed70c395f8b303268f5d00c changed what the response looks like when Zoekt has never loaded a shard: it now reports a `Crashes = 1`, even if everything's fine. That leads to upstream errors where we show an error message in the Sourcegraph admin UI because the customer hasn't added any repositories to their instance yet. The fix here changes the `loader` to also mark the `shardedSearcher` as ready if there was nothing to load. Previously the `markReady` was skipped, the searcher wasn't marked as "ready" and every search query was replied to with a `Crashes = 1`

3 years ago

watcher_test.go

all: gofumpt -l -w . gofumpt is a stricter gofmt. I took a look at the changes and in general they are nice. I don't think we need to enforce the use of gofumpt, but I like the idea of running it every once in a while. Test Plan: go test ./...

2 years ago