zoekt/testdata/ at 44eab0c512ef7ff25b09b2c133d4cba3d9850519 · boltless.me/zoekt · Tangled

boltless.me / zoekt

0

fork of https://github.com/sourcegraph/zoekt

0

zoekt / testdata /

at 44eab0c512ef7ff25b09b2c133d4cba3d9850519 6 folders 2 files

Camden Cheek Always include trailing newline (#747) 2y ago

Always include trailing newline (#747) The updates our "line model" to fix the edge cases that led to sourcegraph/sourcegraph#60605. In short, this changes the definition of a "line" to include its terminating newline (if it exists). Before this, we had defined a "line" as starting at the byte after a newline (or the beginning of a file) and ending at the byte before a newline (or the end of the file). The problem with that definition is that a newline that is the last byte in the file can never successfully be matched because we would trim that from the returned content, so any ranges that would match that trailing newline would be out of bounds in the result returned to the client. That's the reason behind the panics caused by #709, which was an attempt to formalize the "line does not include a trailing newline" definition. So, instead, this redefines a line as ending at the byte after a newline (or the end of the file). This means that a regex can successfully and safely match a terminating newline.

2 years ago

grpc: RepoList: actually persist "repos" field when converting to protobuf message (#644)

2 years ago

Always include trailing newline (#747) The updates our "line model" to fix the edge cases that led to sourcegraph/sourcegraph#60605. In short, this changes the definition of a "line" to include its terminating newline (if it exists). Before this, we had defined a "line" as starting at the byte after a newline (or the beginning of a file) and ending at the byte before a newline (or the end of the file). The problem with that definition is that a newline that is the last byte in the file can never successfully be matched because we would trim that from the returned content, so any ranges that would match that trailing newline would be out of bounds in the result returned to the client. That's the reason behind the panics caused by #709, which was an attempt to formalize the "line does not include a trailing newline" definition. So, instead, this redefines a line as ending at the byte after a newline (or the end of the file). This means that a regex can successfully and safely match a terminating newline.

2 years ago

Add small test for v15 backwards compatibility (#23) * add test for backwards compatibility for v15 * update version * WIP use smaller index Change-Id: Id28f9477a400b7d5649bbc0e8a4d567813792fae * reduce test index + use golden file * cleanup * update test

6 years ago

merging: support exploding compound shards (#271) This change let's us split a compound shard into its constituent repos. In the future this should happen instead of deleting too small compound shards. Fow now, the feature is behind a feature flag. To activate, place a file EXPLODE in the index dir.

4 years ago

ranking: add document ranks to shards (#449) We persist document ranks in the shards and sort file matches based on the rankings determined by the document ranks and match scores. Co-authored-by: Keegan Carruthers-Smith <keegan.csmith@gmail.com>

3 years ago

ci: add shellcheck step (#316)

4 years ago

search_result_1.pb

Add a gRPC API (#577) This adds a gRPC API alongside the existing gob API. It is enabled whenever the RPC setting is enabled. I didn't think it made sense to have a separate setting to enable it. It is only used when a gRPC request is detected (Content-Type: application/grpc). Eventually, we should likely open a separate port for gRPC traffic, but this should be okay for now. In order to minimize the footprint of this change, we only use the protobuf definitions in the RPC layer. They are translated to/from the existing go types. This results in a small perf penalty.

3 years ago