alpha
Login
or
Join now
boltless.me
/
zoekt
Star
0
Fork
0
Atom
Configure Feed
Issues
Pull Requests
Commits
Tags
Feed URL
Select the types of activity you want to include in your feed.
fork of https://github.com/sourcegraph/zoekt
Star
0
Fork
0
Atom
Configure Feed
Issues
Pull Requests
Commits
Tags
Feed URL
Select the types of activity you want to include in your feed.
Overview
Issues
Pulls
Pipelines
zoekt
/
shards
/
at
7ec3d8e8bfc4ef05059b2fa2265d76b48a0cadd6
9 files
Keegan Carruthers-Smith
shards: always aggregate stats for tracing (#729)
2y ago
b08be72e
aggregate.go
shards: always aggregate stats for tracing (#729) Many a time I have seen a slow search without tracing turned on. I then go to visit the net/trace page to see what happened but it is missing the stats to try work out why. This commit will ensure we always log the aggregated statistics. This should be cheap to do given Add is relatively fast and LazyPrintf will only do the stringer operation if someone loads the debug page. It does mean a Stats object lives a bit longer in memory, but it is small. Test Plan: go test
2 years ago
eval.go
shards: always aggregate stats for tracing (#729) Many a time I have seen a slow search without tracing turned on. I then go to visit the net/trace page to see what happened but it is missing the stats to try work out why. This commit will ensure we always log the aggregated statistics. This should be cheap to do given Add is relatively fast and LazyPrintf will only do the stringer operation if someone loads the debug page. It does mean a Stats object lives a bit longer in memory, but it is small. Test Plan: go test
2 years ago
eval_test.go
all: rename module to github.com/sourcegraph/zoekt We are a hard enough for now that we might as well have our own module name. This will also make it possible to more directly use go tooling.
3 years ago
sched.go
scheduler: add some clarifying comments (#508)
3 years ago
sched_test.go
all: fix errcheck lints in test files
4 years ago
shards.go
all: remove deprecated RepoList.Minimal (#624) This field is no longer requested in Sourcegraph and has been deprecated for a while. Test Plan: go test ./...
2 years ago
shards_test.go
all: remove deprecated RepoList.Minimal (#624) This field is no longer requested in Sourcegraph and has been deprecated for a while. Test Plan: go test ./...
2 years ago
watcher.go
Fix no-shards-loaded being reported as crashes (#512) Full debug context here: https://sourcegraph.slack.com/archives/C023ELQLV7F/p1672835804462349 Commit 9899a9b3f475ef066ed70c395f8b303268f5d00c changed what the response looks like when Zoekt has never loaded a shard: it now reports a `Crashes = 1`, even if everything's fine. That leads to upstream errors where we show an error message in the Sourcegraph admin UI because the customer hasn't added any repositories to their instance yet. The fix here changes the `loader` to also mark the `shardedSearcher` as ready if there was nothing to load. Previously the `markReady` was skipped, the searcher wasn't marked as "ready" and every search query was replied to with a `Crashes = 1`
3 years ago
watcher_test.go
shards: unexport NewDirectoryWatcher Does not need to be exported.
3 years ago