zoekt/shards/ at 87a0b748f0caf8209e493479bef144d5ef241677 · boltless.me/zoekt · Tangled

boltless.me / zoekt

0

fork of https://github.com/sourcegraph/zoekt

0

zoekt / shards /

at 87a0b748f0caf8209e493479bef144d5ef241677 9 files

Keegan Carruthers-Smith shards: log typeRepo sub-expression evaluation (#865) 2y ago

shards: log typeRepo sub-expression evaluation (#865) It is hard to tell from net/trace how long we spend evaluating type:repo sub-expressions. This adds in extra logging for when we do that, which should help understand time taken to do this. Test Plan: go test

2 years ago

shards: log typeRepo sub-expression evaluation (#865) It is hard to tell from net/trace how long we spend evaluating type:repo sub-expressions. This adds in extra logging for when we do that, which should help understand time taken to do this. Test Plan: go test

2 years ago

all: rename module to github.com/sourcegraph/zoekt We are a hard enough for now that we might as well have our own module name. This will also make it possible to more directly use go tooling.

3 years ago

scheduler: add some clarifying comments (#508)

3 years ago

all: fix errcheck lints in test files

4 years ago

shards: log to trace on shardedSearcher.Search (#866) This logging is useful since we directly call this search (and avoid typeRepoSearcher) when evaluating List calls for type:repo searches. By adding in this logging we can understand the performance of potentially expensive queries here.

2 years ago

ranking: removing document ranks (#853) Document ranks was an experimental feature of Sourcegraph. We have already removed the code in Sourcegraph in the last release. This is the corresponding cleanup for Zoekt. Test plan: updated tests

2 years ago

shards: only trigger rescan on .zoekt files changing (#801) Any write to the index dir triggered a scan. This means on busy instances we are constantly rescanning, leading to an over-representation in CPU profiles around watch. The events are normally writes to our temporary files. By only considering events for .zoekt files (which is what scan reads) we can avoid the constant scan calls. Just in case we also introduce a re-scan every minute in case we miss an event. There is error handling around this, but I thought it is just more reliable to call scan every once in a while. Note: this doesn't represent significant CPU use, but it does muddy the CPU profiler output. So this makes it easier to understand trends in our continuous cpu profiling. Test Plan: CI

2 years ago

watcher_test.go

all: gofumpt -l -w . gofumpt is a stricter gofmt. I took a look at the changes and in general they are nice. I don't think we need to enforce the use of gofumpt, but I like the idea of running it every once in a while. Test Plan: go test ./...

2 years ago