zoekt/build/ at a0f051e95e82560bd957626b03e7d9dc934d7060 · boltless.me/zoekt · Tangled

boltless.me / zoekt

0

fork of https://github.com/sourcegraph/zoekt

0

zoekt / build /

at a0f051e95e82560bd957626b03e7d9dc934d7060 1 folder 7 files

Julie Tibshirani Ranking: include filename matches in bm25 (#757) 2y ago

Add benchmark for ctags conversion (#679) This change adds a benchmark for the conversion from ctags output to Zoekt document data, plus a tiny optimization to presize the symbol slices.

2 years ago

Ranking: include filename matches in bm25 (#757) BM25 considers a file to be a better match when there are many occurrences of terms in the file. It's important to count all term occurrences, including those in other fields like the filename. For historical reasons, Zoekt trims all filename matches from a result if there are any content matches. This meant that in BM25 scoring, we didn't account for filename matches. This PR refactors the match code so that we only trim filename matches when assembling the final `FileMatch`. We retain filename matches when creating `candidateMatch`, which lets BM25 scoring use them. Even without the better BM25 scoring, I think this refactor makes the code easier to follow.

2 years ago

builder_test.go

all: gofumpt -l -w . gofumpt is a stricter gofmt. I took a look at the changes and in general they are nice. I don't think we need to enforce the use of gofumpt, but I like the idea of running it every once in a while. Test Plan: go test ./...

2 years ago

builder_unix.go

Swap out all usages of the `syscall` package (#513) with the `golang.org/x/sys/unix` package. `syscall` has been frozen since Go 1.3 and deprecated (https://go.dev/doc/go1.4#major_library_changes). Using the `golang.org/x/sys/unix` package will bring in bug fixes and enhancements since `syscall` was frozen in 1.3, and will pave the way for multi-platform builds (which will affect only the single-program local install, most likely).

3 years ago

all: use stdlib slices package (#735) Noticed we weren't using this yet and that the API signatures had changed. Test Plan: go test

2 years ago

Indexing: clean up ctags parser wrapper (#708) This change cleans up the Go ctags parser wrapper as a follow-up to #702. Specific changes: * Remove synchronization in `lockedParser` and rename it to `CTagsParser` * Push delegation to universal vs. SCIP ctags into parser wrapper * Simplify document timeout logic * Rename some files

2 years ago

all: gofumpt -l -w . gofumpt is a stricter gofmt. I took a look at the changes and in general they are nice. I don't think we need to enforce the use of gofumpt, but I like the idea of running it every once in a while. Test Plan: go test ./...

2 years ago

scoring_test.go

Ranking: include filename matches in bm25 (#757) BM25 considers a file to be a better match when there are many occurrences of terms in the file. It's important to count all term occurrences, including those in other fields like the filename. For historical reasons, Zoekt trims all filename matches from a result if there are any content matches. This meant that in BM25 scoring, we didn't account for filename matches. This PR refactors the match code so that we only trim filename matches when assembling the final `FileMatch`. We retain filename matches when creating `candidateMatch`, which lets BM25 scoring use them. Even without the better BM25 scoring, I think this refactor makes the code easier to follow.

2 years ago