zoekt/shards/ at adf376d3ed3cb2bb20dd66c35e2885b886b05ed9 · boltless.me/zoekt · Tangled

boltless.me / zoekt

0

fork of https://github.com/sourcegraph/zoekt

0

zoekt / shards /

at adf376d3ed3cb2bb20dd66c35e2885b886b05ed9 9 files

Dave Try remove bazel (#634) 2y ago

introduce DisplayTruncator (#630) This moves all decisions about if we should do display limits and how to enforce them into one place. By default we make it stateful so it can be used by the limitSender. But in every other place we will always sort and then truncate, so we also introduce a convenience API for that. The only potential behaviour change here is if you have no display limits but had document ranks turned on, we would not sort matches within a shard. However, the aggregator would still do sorting anyways so this is really just a wasted sort. In practice a display limit should always be set. Test Plan: go test

2 years ago

fix tracing (#627) In #187 we collapsed the spans which caused all the LazyPrintf in defer statements to be dropped. In this PR I revert #187, deduplicate trace logs (EG we logged "num files" and `opts` in multiple places) and log `stats` in streaming search. Test plan: I confirmed locally that the logs show up as expected.

2 years ago

all: rename module to github.com/sourcegraph/zoekt We are a hard enough for now that we might as well have our own module name. This will also make it possible to more directly use go tooling.

3 years ago

scheduler: add some clarifying comments (#508)

3 years ago

all: fix errcheck lints in test files

4 years ago

introduce DisplayTruncator (#630) This moves all decisions about if we should do display limits and how to enforce them into one place. By default we make it stateful so it can be used by the limitSender. But in every other place we will always sort and then truncate, so we also introduce a convenience API for that. The only potential behaviour change here is if you have no display limits but had document ranks turned on, we would not sort matches within a shard. However, the aggregator would still do sorting anyways so this is really just a wasted sort. In practice a display limit should always be set. Test Plan: go test

2 years ago

shards: populate RepoList.Stats.Repos (#605) Previously this was only populated by the web package for serving a specific endpoint. We now populate it in all places we do aggregation. Test Plan: updated unit tests. Additionally loaded zoekt-webserver then added to the index a repository which required 2 shards to index. The repository count shown only increased by 1.

3 years ago

Fix no-shards-loaded being reported as crashes (#512) Full debug context here: https://sourcegraph.slack.com/archives/C023ELQLV7F/p1672835804462349 Commit 9899a9b3f475ef066ed70c395f8b303268f5d00c changed what the response looks like when Zoekt has never loaded a shard: it now reports a `Crashes = 1`, even if everything's fine. That leads to upstream errors where we show an error message in the Sourcegraph admin UI because the customer hasn't added any repositories to their instance yet. The fix here changes the `loader` to also mark the `shardedSearcher` as ready if there was nothing to load. Previously the `markReady` was skipped, the searcher wasn't marked as "ready" and every search query was replied to with a `Crashes = 1`

3 years ago

watcher_test.go

shards: unexport NewDirectoryWatcher Does not need to be exported.

3 years ago